Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sitemap] Introduce "Buttongrid" as new sitemap element #3810

Merged
merged 1 commit into from
Oct 1, 2023

Conversation

lolodomo
Copy link
Contributor

Related to #3441

Signed-off-by: Laurent Garnier [email protected]

@lolodomo lolodomo requested a review from a team as a code owner September 24, 2023 07:49
@lolodomo lolodomo marked this pull request as draft September 24, 2023 07:49
@lolodomo lolodomo marked this pull request as ready for review September 24, 2023 17:15
@lolodomo
Copy link
Contributor Author

@openhab/core-maintainers : would it be possible to consider this PR relatively soon to let time to each sitemap UI to implement the new feature before OH 4.1 is released?

@jlaur
Copy link
Contributor

jlaur commented Sep 30, 2023

Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm. Let's see how the UI implementations will look like. 😄

@kaikreuzer kaikreuzer merged commit 366bffa into openhab:main Oct 1, 2023
2 checks passed
@kaikreuzer kaikreuzer added the enhancement An enhancement or new feature of the Core label Oct 1, 2023
@kaikreuzer kaikreuzer added this to the 4.1 milestone Oct 1, 2023
@lolodomo lolodomo deleted the sitemap_buttongrid branch October 1, 2023 20:24
@lolodomo
Copy link
Contributor Author

lolodomo commented Oct 1, 2023

Thank you Kai

lolodomo added a commit to lolodomo/openhab-core that referenced this pull request Dec 4, 2023
Follow-up openhab#3810

Location in the grid is now defined by a line number and a column number.

Signed-off-by: Laurent Garnier <[email protected]>
lolodomo added a commit to lolodomo/openhab-core that referenced this pull request Dec 4, 2023
Follow-up openhab#3810

Location in the grid is now defined by a line number and a column number.

Signed-off-by: Laurent Garnier <[email protected]>
lolodomo added a commit to lolodomo/openhab-core that referenced this pull request Dec 5, 2023
Follow-up openhab#3810

Location in the grid is now defined by a row number and a column number.

Signed-off-by: Laurent Garnier <[email protected]>
kaikreuzer pushed a commit that referenced this pull request Dec 5, 2023
Follow-up #3810

Location in the grid is now defined by a row number and a column number.

Signed-off-by: Laurent Garnier <[email protected]>
ghys pushed a commit to openhab/openhab-webui that referenced this pull request Dec 13, 2023
This PR adds the Buttongrid element to the sitemap editor.
There is also some cleanup for configuration on small screens.
See openhab/openhab-core#3810 and
openhab/openhab-android#3494

---------

Signed-off-by: Mark Herwege <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants