-
-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sitemap] Introduce "Buttongrid" as new sitemap element #3810
Conversation
Related to openhab#3441 Signed-off-by: Laurent Garnier <[email protected]>
6bb8a79
to
584625b
Compare
@openhab/core-maintainers : would it be possible to consider this PR relatively soon to let time to each sitemap UI to implement the new feature before OH 4.1 is released? |
Small note to add this keyword to https://github.com/airix1/openhabnano/blob/1e28b75082c01f67e7f1400694fab114ba874609/openhab.nanorc#L31-L34 when merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code lgtm. Let's see how the UI implementations will look like. 😄
Thank you Kai |
Follow-up openhab#3810 Location in the grid is now defined by a line number and a column number. Signed-off-by: Laurent Garnier <[email protected]>
Follow-up openhab#3810 Location in the grid is now defined by a line number and a column number. Signed-off-by: Laurent Garnier <[email protected]>
Follow-up openhab#3810 Location in the grid is now defined by a row number and a column number. Signed-off-by: Laurent Garnier <[email protected]>
Follow-up #3810 Location in the grid is now defined by a row number and a column number. Signed-off-by: Laurent Garnier <[email protected]>
This PR adds the Buttongrid element to the sitemap editor. There is also some cleanup for configuration on small screens. See openhab/openhab-core#3810 and openhab/openhab-android#3494 --------- Signed-off-by: Mark Herwege <[email protected]>
Related to #3441
Signed-off-by: Laurent Garnier [email protected]