ActionInputsHelper: Allow any number of decimals & Apply primitive input default values #4424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
florian-h05
commented
Oct 26, 2024
florian-h05
commented
- Set the step size of the config description parameter to 0 if the paramerer type is decimal, which enables the UI to allow entering any number of decimals (see Number parameter: Allow configuring any step size/number of decimals openhab-webui#2832).
- Apply the default value for primitive action inputs that have a default value (has been forgotten in Enhance ThingActions UI support #4392).
This makes the UI allow any step size, i.e. entering any number of decimals. Signed-off-by: Florian Hotze <[email protected]>
…to action inputs This has been forgotten to be implemented. Signed-off-by: Florian Hotze <[email protected]>
J-N-K
approved these changes
Oct 26, 2024
|
Yes @florian-h05 and @J-N-K , that is fine for me, thank you. |
|
FYI #4425 documents that any number of decimals can be allowed by setting step size to 0. |
|
@J-N-K Can you please merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.