[ColorUtil] kelvinToXY: Extend Colour Temperature range 1000 K .. 10000 K #4429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AndrewFG <[email protected]>
|
=> @lolodomo for info |
6 tasks
andrewfg
changed the title
There was a problem hiding this comment.
Hi @andrewfg,
could we consider restricting the number of tests runs to a reasonable number? 270000 tests take quite a while to complete.
Mybe increasing allHSB::step to 20 and allRGBW::step to 25 could be a compromise.... WDYT?
|
Yeah. :) EDIT: done! |
Signed-off-by: AndrewFG <[email protected]>
andrewfg
changed the title
andrewfg
changed the title
bundles/org.openhab.core/src/test/java/org/openhab/core/util/ColorUtilTest.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.core/src/test/java/org/openhab/core/util/ColorUtilTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: AndrewFG <[email protected]>
holgerfriedrich
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the supported colour temperature range of the
kelvinToXy()method from 2000 .. 6500 K to 1000 .. 10000 KSee #3891 (comment)
Please note that the inverse
xyToKelvin()method (which is based on McCamy's approximation) is only accurate above 2000 K. This means that round trip conversionsxyToKelvin(kelvinToXy())are very inaccurate for colour temperatures below 2000 K. This is not perfect but it seems that most real bindings in OH are using a range of 2000 K to 6500 K .. where the accuracy is better than 1%..Signed-off-by: AndrewFG [email protected]