Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add breaking change alert for ISM8 #1477

Merged
merged 6 commits into from
Feb 25, 2024
Merged

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Mar 7, 2023

add breaking change alert for ISM8

related to: openhab/openhab-addons#14206

Signed-off-by: lsiepel <[email protected]>
@lsiepel lsiepel requested a review from a team as a code owner March 7, 2023 07:52
@wborn wborn added the awaiting other PR Depends on another PR label Mar 8, 2023
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be moved to the right OH version when it gets merged.

@lsiepel
Copy link
Contributor Author

lsiepel commented Sep 22, 2023

Tried to fix the DCO with commit amend, somehow i failed. Anyway, i guess it should not be an issue as it only is a commit to change the line+ version numbner.

Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is a 4.1.0 release now, it again should be moved to the right OH version when it gets merged.

Signed-off-by: Leo Siepel <[email protected]>
@lsiepel
Copy link
Contributor Author

lsiepel commented Dec 29, 2023

As there is a 4.1.0 release now, it again should be moved to the right OH version when it gets merged.

Done.

@kaikreuzer kaikreuzer removed the awaiting other PR Depends on another PR label Feb 25, 2024
@kaikreuzer kaikreuzer merged commit a4db76e into openhab:main Feb 25, 2024
2 of 3 checks passed
@kaikreuzer kaikreuzer added this to the 4.2 milestone Feb 25, 2024
@lsiepel lsiepel deleted the ism8-notice branch February 25, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants