Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[audio] Reencode the doorbell.mp3 sample file #1579

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

dalgwen
Copy link
Contributor

@dalgwen dalgwen commented Aug 21, 2023

Reencode doorbell.mp3 , as it cannot be played on the webaudio sink on firefox (but worked fine on chrome).
I also shortened it a bit (there was several seconds of nearly blank sound at the end of the file).

(from this post)

Reencode doorbell.mp3 , as it cannot be played on the webaudio sink on firefox (but worked fine on chrome)

Signed-off-by: Gwendal Roulleau <[email protected]>
@dalgwen dalgwen requested a review from a team as a code owner August 21, 2023 10:35
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the door bell!
Now people no longer have to knock on the door. 😉

@wborn wborn merged commit aaa76ce into openhab:main Aug 21, 2023
3 checks passed
@wborn wborn added the bug An unexpected problem or unintended behavior label Aug 21, 2023
@wborn wborn added this to the 4.1 milestone Aug 21, 2023
@dalgwen dalgwen deleted the doorbell_reencode branch October 1, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants