Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package addons.xml with the distro instead of as an external feature #1620

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

kaikreuzer
Copy link
Member

No description provided.

@J-N-K
Copy link
Member

J-N-K commented Dec 20, 2023

If we do it like this, the file is not replaced when cache is cleared, correct? I'm not sure if it is necessary to update it in this case, because if you clear cache (on a snapshot), other versions of addons will be installed, which might need the updated addon.xml

@kaikreuzer
Copy link
Member Author

Correct. But I don't consider cache cleaning a valid operation anyhow, especially not on snapshots. There might also be a new feature in core that the newer snapshot add-ons rely on, while it isn't present in the old snapshot core.

@kaikreuzer kaikreuzer marked this pull request as draft December 20, 2023 21:36
@J-N-K
Copy link
Member

J-N-K commented Dec 20, 2023

Look good. I assume you checked it works? I'm on the phone, so can't check that.

@kaikreuzer kaikreuzer marked this pull request as ready for review December 20, 2023 22:12
@kaikreuzer
Copy link
Member Author

I checked that the packaging works, yes, and I have moved the file now to runtime/etc.
Additionally, I have created openhab/openhab-core#3944, so that the core is looking for the file at the new location.
Would be great, if both could be still reviewed/merged tonight, so that we have a new snapshot for tests tomorrow morning.

launch/app/app.bndrun Outdated Show resolved Hide resolved
@kaikreuzer kaikreuzer merged commit 23daf0e into openhab:main Dec 20, 2023
1 of 3 checks passed
@kaikreuzer kaikreuzer deleted the addonsxml branch December 20, 2023 22:56
@andrewfg
Copy link
Contributor

@kaikreuzer / @J-N-K / @mherwege we have now successfully merged the USB serial suggestion finder service (for suggesting bindings that depend on USB serial devices); and consequently we also have added the discovery-methods to the addon.xml files for the ZigBee and Z-Wave bindings. The last step therefore is to include those two individual addon.xml files into the OH combined addons.xml file. But I don't know how to do that. => Any suggestions?

@wborn
Copy link
Member

wborn commented Jan 4, 2024

But I don't know how to do that. => Any suggestions?

#1626

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants