Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Karaf 4.4.5 #1637

Merged
merged 5 commits into from
Mar 17, 2024
Merged

Upgrade to Karaf 4.4.5 #1637

merged 5 commits into from
Mar 17, 2024

Conversation

holgerfriedrich
Copy link
Member

@holgerfriedrich holgerfriedrich requested a review from a team as a code owner March 5, 2024 21:18
@holgerfriedrich holgerfriedrich added the work in progress A PR that is not yet ready to be merged label Mar 5, 2024
@holgerfriedrich holgerfriedrich removed the work in progress A PR that is not yet ready to be merged label Mar 9, 2024
@holgerfriedrich holgerfriedrich changed the title [WIP] Upgrade to Karaf 4.4.5 Upgrade to Karaf 4.4.5 Mar 9, 2024
Comment on lines -126 to -127
org.ops4j.pax.logging.pax-logging-api;version='[2.2.3,2.2.4)',\
org.ops4j.pax.logging.pax-logging-log4j2;version='[2.2.3,2.2.4)',\
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC the Pax Logging bundles are at the top so those bundles are started first so the log levels are applied immediately which prevents noisy debug/trace logging at startup.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have a look. I was thought not to touch whatever the resolver creates ;-)

Comment on lines 250 to 254
org.openhab.ui.basic;version='[4.2.0,4.2.1)',\
org.openhab.ui.iconset.classic;version='[4.2.0,4.2.1)'
org.openhab.ui.iconset.classic;version='[4.2.0,4.2.1)',\
com.google.guava;version='[33.0.0,33.0.1)',\
com.google.guava.failureaccess;version='[1.0.2,1.0.3)',\
com.sun.jna;version='[5.14.0,5.14.1)',\
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always keep the bundles sorted as sometimes the bundle order causes very slow bundle resolution, see: https://community.openhab.org/t/starting-demo-app-takes-ages-10-12min-on-every-run-osgi-startup/122083

Signed-off-by: Holger Friedrich <[email protected]>
@holgerfriedrich
Copy link
Member Author

@wborn diff looks much better now, hope I did not break anything....

Signed-off-by: Holger Friedrich <[email protected]>
Signed-off-by: Holger Friedrich <[email protected]>
@holgerfriedrich holgerfriedrich removed the awaiting other PR Depends on another PR label Mar 17, 2024
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@wborn wborn merged commit d39aa87 into openhab:main Mar 17, 2024
3 checks passed
@wborn wborn added this to the 4.2 milestone Mar 17, 2024
@holgerfriedrich holgerfriedrich deleted the k445 branch March 17, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants