-
-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add breaking change warning for openhab-js #1646
Conversation
@@ -134,6 +134,7 @@ ALERT;Twitter Binding has become X. All related references to Twitter and Tweets | |||
ALERT;AndroidTV Binding: The thing configuration of 'port' has been renamed and split to 'googletvPort' and 'shieldtvPort' | |||
ALERT;evcc Binding: Update to evcc API version 0.123.1 results in several new or updated channels. Existing Items will need to be adjusted. | |||
ALERT;ISM8 Binding: Most channels have changed and are now using Units of Measurements. Items must be adapted and the things must be recreated. | |||
ALERT;JavaScript Scripting Automation: The 'Item' suffix has been removed from Item.type, i.e. 'SwitchItem' becomes 'Switch'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also document the action users need to do e.g. update rules? Is this optional or mandatory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That’s quite difficult because there is much you can do with this.
E.g. for logging, this change doesn’t matter, but when using the equals operator to check for a given Item type, you would need to update one side of the comparison.
@florian-h05 can you please rebase? |
Signed-off-by: Florian Hotze <[email protected]>
@holgerfriedrich Done 👍 |
Converting to draft as I will add more warnings soon. |
5b0af4e
to
e9e55c4
Compare
@kaikreuzer Can you please merge this PR for the next milestone? |
Refs https://github.com/openhab/openhab-js/blob/main/CHANGELOG.md#500. Signed-off-by: Florian Hotze <[email protected]>
Refs https://github.com/openhab/openhab-js/blob/main/CHANGELOG.md#490
and https://github.com/openhab/openhab-js/blob/main/CHANGELOG.md#500.