Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix demo setup for dev (Basic UI + transform) #1665

Merged
merged 1 commit into from
Jun 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion launch/app/runtime/conf/transform/de.map
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
CLOSED=zu
OPEN=offen
undefined=undefiniert
-=-
NULL=undefiniert
UNDEF=unbekannt
3 changes: 2 additions & 1 deletion launch/app/runtime/conf/transform/en.map
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
CLOSED=closed
OPEN=open
undefined=unknown
-=-
NULL=undefined
UNDEF=unknown
4 changes: 1 addition & 3 deletions launch/app/runtime/services.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,7 @@ folder:persistence=persist
folder:things=things

basicui:defaultSitemap=demo
basicui:enableIcons=true
basicui:condensedLayout=false
basicui:capitalizeValues=false
basicui:inlineSvg=false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you briefly elaborate these changes? I am not fully clear, why they are done.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, ok, it is the demo setup and you simply removed the things that are anyhow the default values, I guess.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Basic UI settings are now on client side (browser).
They do not exist anymore on OH server side, except inlineSvg and defaultSitemap.


# Uncomment to enable rest api CORS requests
# cors:enable=true
Expand Down