Blockly: Support String/Number/Quantity on eventcontext state/command #1992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Höhn <[email protected]>
|
Awesome! Could it also support Quantity? |
Job #1087: Bundle Size — 15.75MiB (~+0.01%).Metrics (no changes)
Total size by type (2 changes)
|
Signed-off-by: Florian Hotze <[email protected]>
florian-h05
changed the title
Signed-off-by: Florian Hotze <[email protected]>
florian-h05
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
You forgot to update the code generation, I did it.
@rkoshak I've added Quantity.
florian-h05
added
bug
florian-h05
pushed a commit
that referenced
this pull request
Jul 27, 2023
Fixes #1991. Support conversion of event context types itemState, oldItemState, itemCommand as String or Number by supplying a mutating block with a choise of Number / String. Also-by: Florian Hotze <[email protected]> Signed-off-by: Stefan Höhn <[email protected]> (cherry picked from commit edc124e)
florian-h05
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1991.
Support conversion of event context types itemState, oldItemState, itemCommand as String or Number by supplying a mutating block with a choise of Number / String.