Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix color picker not displayed correctly #2136

Merged
merged 1 commit into from
Oct 29, 2023
Merged

Fix color picker not displayed correctly #2136

merged 1 commit into from
Oct 29, 2023

Conversation

florian-h05
Copy link
Contributor

Fixes #2134.
Regression from #1989.

@florian-h05
Fix color picker not displaying color sliders
d6d1284 
Fixes openhab#2134.
Regression from openhab#1989.

Signed-off-by: Florian Hotze <[email protected]>
@florian-h05 florian-h05 requested a review from a team as a code owner October 14, 2023 22:53
@florian-h05 florian-h05 added bug Something isn't working main ui Main UI regression labels Oct 14, 2023
@florian-h05 florian-h05 changed the title Fix color picker not displaying color sliders Fix color picker not displayed correctly Oct 14, 2023
@relativeci
Copy link

relativeci bot commented Oct 14, 2023

Job #1207: Bundle Size — 15.79MiB (+0.2%).

d6d1284(current) vs b7270d2 main#1158(baseline)

Warning

Bundle contains 16 duplicate packages – View duplicate packages

Warning

Bundle introduced 13 new packages: @jsep-plugin/regex, @jsep-plugin/arrow, @jsep-plugin/object and 10 more – View changed packages

Bundle metrics  Change 10 changes Regression 5 regressions Improvement 1 improvement
                 Current
Job #1207		      Baseline
Job #1158
Regression  Initial JS 1.85MiB(+10.95%) 1.67MiB
Regression  Initial CSS 608.95KiB(+0.01%) 608.89KiB
Change  Cache Invalidation 93.81% 93.95%
Change  Chunks 217(-0.91%) 219
Change  Assets 683(-0.87%) 689
Change  Modules 2987(+75.71%) 1700
Regression  Duplicate Modules 173(+92.22%) 90
Improvement  Duplicate Code 1.61%(-17.44%) 1.95%
Regression  Packages 152(+10.14%) 138
Regression  Duplicate Packages 16(+6.67%) 15
Bundle size by type  Change 3 changes Regression 3 regressions
                 Current
Job #1207		      Baseline
Job #1158
Regression  JS 9.28MiB (+0.24%) 9.25MiB
Regression  Other 4.74MiB (+0.19%) 4.73MiB
Regression  CSS 860.19KiB (+0.08%) 859.49KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.23KiB 1.23KiB

View job #1207 report View florian-h05:bug-2134 branch activity

@Mark-VG
Copy link

Mark-VG commented Oct 15, 2023

Hi.
Any chance of a jar for this to try before merge. Hoping it fixes the issue I am seeing.

@florian-h05
Copy link
Contributor Author

Sure: https://we.tl/t-safSYPMgG8.

@Mark-VG
Copy link

Mark-VG commented Oct 15, 2023

Sure: https://we.tl/t-safSYPMgG8.

Thank you.

Same instructions as firvtge other one?

Deploy it to your addons folder, and log into the Karaf console:

bundle:list org.openhab.ui

Stop the milestone bundle, restart the other one.

bundle:stop ID and bundle:restart ID.

@florian-h05
Copy link
Contributor Author

Exactly.
You can also stop the milestone bundle before dropping the JAR into the addons folder.

@Mark-VG
Copy link

Mark-VG commented Oct 15, 2023 •
edited
Loading

Thank you so much. Seems to have fixed my issue too :-) Also the reload does not happen any more when setting the "H".

image

@florian-h05
Copy link
Contributor Author

Self-merging this small PR to finally fix the broken color picker.

Please note that the added width: 100% is already applied to the color picker‘s div, it is just missing for the wrapping div.

@florian-h05 florian-h05 merged commit c9de04e into openhab:main Oct 29, 2023
6 checks passed
@florian-h05 florian-h05 deleted the bug-2134 branch October 29, 2023 13:51
@florian-h05 florian-h05 added this to the 4.1 milestone Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI regression
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

Color Widget lacks default module setting
2 participants
@florian-h05 @Mark-VG