-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sitemap editor: Add Buttongrid Button support #2755
Conversation
Probably better to first finish #2720 first and then rebase on that. The impact starts to be pretty big. |
#2339 Bundle Size — 10.84MiB (+0.06%).011bec8(current) vs 2975d78 main#2338(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
Current #2339 |
Baseline #2338 |
|
---|---|---|
Initial JS | 1.89MiB (+0.02% ) |
1.89MiB |
Initial CSS | 576.8KiB |
576.8KiB |
Cache Invalidation | 22.9% |
22.78% |
Chunks | 226 |
226 |
Assets | 249 |
249 |
Modules | 2918 |
2918 |
Duplicate Modules | 149 |
149 |
Duplicate Code | 1.8% |
1.8% |
Packages | 96 |
96 |
Duplicate Packages | 2 |
2 |
Bundle size by type 1 change
1 regression
Current #2339 |
Baseline #2338 |
|
---|---|---|
JS | 9.05MiB (+0.07% ) |
9.04MiB |
CSS | 863.56KiB |
863.56KiB |
Fonts | 526.1KiB |
526.1KiB |
Media | 295.6KiB |
295.6KiB |
IMG | 140.74KiB |
140.74KiB |
HTML | 1.38KiB |
1.38KiB |
Other | 871B |
871B |
Bundle analysis report Branch mherwege:buttongrid_button Project dashboard
Generated by RelativeCI Documentation Report issue
3e3939d
to
26f3384
Compare
8ec08b8
to
4cfa35b
Compare
Dependency openhab/openhab-core#4377 Is now merged. |
I just triggered a rebuild of your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to give this a try by creating a new (hence empty) sitemap, but I cannot save that empty sitemap.
If I add a widget to it, I can save it.
@mherwege Can you please have a look?
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]> Signed-off-by: Mark Herwege <[email protected]>
This reverts commit 7f23b21. Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
e2ed1d1
to
011bec8
Compare
It looks like that bug was there before this PR. It should be fixed now. |
I though it was a regression from this PR, anyway thanks for the fix! |
Sorry for that. I normally don’t, but I made the mistake a few weeks ago to merge main into the branch from the web, and I couldn’t get it to push anymore without a rebase and force push. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Refs openhab/openhab-core#4377. The most recent addition to the sitemap syntax allows defining buttons nested as components inside the Buttongrid component. --------- Signed-off-by: Mark Herwege <[email protected]>
Refs openhab/openhab-core#4377.
The most recent addition to the sitemap syntax allows defining buttons nested as components inside the Buttongrid component.