Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thing add page: Add support for optional scan input #2771

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented Sep 30, 2024

Copy link

relativeci bot commented Sep 30, 2024

#2283 Bundle Size — 10.82MiB (+0.01%).

1de9695(current) vs 217fc06 main#2280(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
#2283
     Baseline
#2280
No change  Initial JS 1.89MiB 1.89MiB
No change  Initial CSS 576.5KiB 576.5KiB
Change  Cache Invalidation 18.15% 0.01%
No change  Chunks 226 226
No change  Assets 249 249
No change  Modules 2920 2920
No change  Duplicate Modules 149 149
No change  Duplicate Code 1.8% 1.8%
No change  Packages 96 96
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2283
     Baseline
#2280
Regression  JS 9.04MiB (+0.01%) 9.04MiB
No change  CSS 863.22KiB 863.22KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.39KiB 1.39KiB
No change  Other 871B 871B

Bundle analysis reportBranch florian-h05:thing-add-scaninputProject dashboard


Generated by RelativeCIDocumentationReport issue

@florian-h05 florian-h05 merged commit 38a486a into openhab:main Sep 30, 2024
8 checks passed
@florian-h05 florian-h05 deleted the thing-add-scaninput branch September 30, 2024 13:32
@lolodomo
Copy link
Contributor

Tested and it works exactly as we expected. Top. @digitaldan you can now rely on this new feature and remove pairing code as thing configuration and as thing channel.

@florian-h05 I just saw a little bug in rendering with a text almost hidden:
image

@florian-h05
Copy link
Contributor Author

@lolodomo Thanks for noticing … this is cause by a „quick-and-dirty“ style fix I used, I should probably do it the clean way now.

florian-h05 added a commit to florian-h05/openhab-webui that referenced this pull request Sep 30, 2024
florian-h05 added a commit that referenced this pull request Sep 30, 2024
@lolodomo
Copy link
Contributor

lolodomo commented Oct 1, 2024

@florian-h05 : final step would be to also propose to scan a QR code. Is there something like that in "HTML" standard ?

@florian-h05
Copy link
Contributor Author

I have already played around with QR code scanners in the browser in a little side project … so it is possible. These pairing code QR codes only contain the pairing code itself or additional data?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants