Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config sheet: Properly handle null as configuration value #2773

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented Sep 30, 2024

This fixes an error that was previously thrown.

backend.js:5526 TypeError: Cannot read properties of null (reading 'toString')
    at eval (index.js??vue-loader-options!./src/components/config/config-sheet.vue?vue&type=script&lang=js:57:133)
    at Array.filter (<anonymous>)
    at VueComponent.displayedParameters (index.js??vue-loader-options!./src/components/config/config-sheet.vue?vue&type=script&lang=js:56:30)
    at Watcher.get (vue.esm.js:4223:33)
    at Watcher.evaluate (vue.esm.js:4324:27)
    at VueComponent.computedGetter [as displayedParameters] (vue.esm.js:4547:25)
    at Object.get (vue.esm.js:771:26)
    at Proxy.render (templateLoader.js??ruleSet[1].rules[2]!./node_modules/vue-loader/lib/index.js??vue-loader-options!./src/components/config/config-sheet.vue?vue&type=template&id=23208b3e:34:11)
    at Vue._render (vue.esm.js:2591:28)
    at VueComponent.updateComponent (vue.esm.js:3137:27)

@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Sep 30, 2024
@florian-h05 florian-h05 added this to the 4.3 milestone Sep 30, 2024
Copy link

relativeci bot commented Sep 30, 2024

#2290 Bundle Size — 10.82MiB (~+0.01%).

9e89c15(current) vs e742d7a main#2286(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#2290
     Baseline
#2286
Regression  Initial JS 1.89MiB(~+0.01%) 1.89MiB
No change  Initial CSS 576.5KiB 576.5KiB
Change  Cache Invalidation 19.19% 18.15%
No change  Chunks 226 226
No change  Assets 249 249
No change  Modules 2920 2920
No change  Duplicate Modules 149 149
No change  Duplicate Code 1.8% 1.8%
No change  Packages 96 96
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2290
     Baseline
#2286
Regression  JS 9.04MiB (~+0.01%) 9.04MiB
No change  CSS 863.22KiB 863.22KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.39KiB 1.39KiB
No change  Other 871B 871B

Bundle analysis reportBranch florian-h05:config-sheet-nullProject dashboard


Generated by RelativeCIDocumentationReport issue

This fixes an error that was previously thrown.

Signed-off-by: Florian Hotze <[email protected]>
@florian-h05 florian-h05 merged commit 1ea84a1 into openhab:main Sep 30, 2024
8 checks passed
@florian-h05 florian-h05 deleted the config-sheet-null branch September 30, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant