Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Z-Wave network map: Fix ECharts deprecation warnings #2774

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Z-Wave network map: Fix ECharts deprecation warnings #2774

merged 1 commit into from
Sep 30, 2024

Conversation

florian-h05
Copy link
Contributor

No description provided.

@florian-h05 florian-h05 added the main ui Main UI label Sep 30, 2024
@florian-h05
Copy link
Contributor Author

@stefan-hoehn IIRC you have Z-Wave devices. Can you please check if the network map still works?

@relativeci RelativeCI
Copy link

relativeci bot commented Sep 30, 2024

#2289 Bundle Size — 10.82MiB (~-0.01%).

eb58fc7(current) vs e742d7a main#2286(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
#2289		      Baseline
#2286
No change  Initial JS 1.89MiB 1.89MiB
No change  Initial CSS 576.5KiB 576.5KiB
Change  Cache Invalidation 19.47% 18.15%
No change  Chunks 226 226
No change  Assets 249 249
No change  Modules 2920 2920
No change  Duplicate Modules 149 149
No change  Duplicate Code 1.8% 1.8%
No change  Packages 96 96
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
#2289		      Baseline
#2286
Improvement  JS 9.04MiB (~-0.01%) 9.04MiB
No change  CSS 863.22KiB 863.22KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.39KiB 1.39KiB
No change  Other 871B 871B

Bundle analysis report Branch florian-h05:zwave-network-map Project dashboard

Generated by RelativeCI Documentation Report issue

@florian-h05 florian-h05 added the enhancement New feature or request label Sep 30, 2024
stefan-hoehn
stefan-hoehn approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@stefan-hoehn stefan-hoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, works like a charm with this PR:

image

@florian-h05 florian-h05 changed the title Z-Wave network: Fix ECharts deprecation warnings Z-Wave network map: Fix ECharts deprecation warnings Sep 30, 2024
@florian-h05 florian-h05 added this to the 4.3 milestone Sep 30, 2024
@florian-h05 florian-h05 merged commit 91c7c16 into openhab:main Sep 30, 2024
8 checks passed
@florian-h05 florian-h05 deleted the zwave-network-map branch September 30, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefan-hoehn stefan-hoehn stefan-hoehn approved these changes

@ghys ghys Awaiting requested review from ghys ghys is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@florian-h05 @stefan-hoehn