Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addons store: Multiple styling improvements #2833

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented Oct 25, 2024

Follow-up for #2216.

  • Do not use addon swiper on iPad.
  • Revert addon card size changes.
  • Show more addon cards in swiper in landscape mode.

@florian-h05 florian-h05 added the main ui Main UI label Oct 25, 2024
@florian-h05 florian-h05 added this to the 4.3 milestone Oct 25, 2024
Copy link

relativeci bot commented Oct 25, 2024

#2420 Bundle Size — 10.85MiB (~+0.01%).

1107b06(current) vs c225819 main#2419(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
#2420
     Baseline
#2419
No change  Initial JS 1.9MiB 1.9MiB
No change  Initial CSS 577.21KiB 577.21KiB
Change  Cache Invalidation 17.74% 17.53%
No change  Chunks 226 226
No change  Assets 249 249
No change  Modules 2930 2930
No change  Duplicate Modules 151 151
No change  Duplicate Code 1.88% 1.88%
No change  Packages 96 96
No change  Duplicate Packages 2 2
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#2420
     Baseline
#2419
Regression  JS 9.06MiB (~+0.01%) 9.06MiB
Improvement  CSS 864.11KiB (~-0.01%) 864.19KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis reportBranch florian-h05:addon-storeProject dashboard


Generated by RelativeCIDocumentationReport issue

@florian-h05 florian-h05 marked this pull request as draft October 25, 2024 13:17
@florian-h05
Copy link
Contributor Author

Todo: Show more slider elements in landscape mode.

@florian-h05 florian-h05 changed the title Addons store: Don't use slider on iPad & Revert addon card size change Addons store: Multiple styling improvements Oct 25, 2024
@florian-h05 florian-h05 marked this pull request as ready for review October 25, 2024 23:10
@florian-h05 florian-h05 merged commit 3166955 into openhab:main Oct 25, 2024
8 checks passed
@florian-h05 florian-h05 deleted the addon-store branch October 25, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant