Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thing actions: Sort by label, Show description, Hide unsupported actions #2834

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

florian-h05
Copy link
Contributor

Follow-up for #2818.

Copy link

relativeci bot commented Oct 25, 2024

#2422 Bundle Size — 10.85MiB (~+0.01%).

2cf3a69(current) vs 3166955 main#2421(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#2422
     Baseline
#2421
Regression  Initial JS 1.9MiB(~+0.01%) 1.9MiB
No change  Initial CSS 577.21KiB 577.21KiB
Change  Cache Invalidation 18.19% 17.74%
No change  Chunks 226 226
No change  Assets 249 249
No change  Modules 2930 2930
No change  Duplicate Modules 151 151
No change  Duplicate Code 1.88% 1.88%
No change  Packages 96 96
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2422
     Baseline
#2421
Regression  JS 9.06MiB (~+0.01%) 9.06MiB
No change  CSS 864.11KiB 864.11KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis reportBranch florian-h05:thing-actionsProject dashboard


Generated by RelativeCIDocumentationReport issue

@florian-h05 florian-h05 merged commit b9edd97 into openhab:main Oct 25, 2024
8 checks passed
@florian-h05 florian-h05 deleted the thing-actions branch October 25, 2024 23:45
@lolodomo
Copy link
Contributor

lolodomo commented Oct 27, 2024

@florian-h05 : I started to test the new snapshot and check what actions are shown on my different things. I discovered a very minor "issue": For my hue things, I see the title "Actions" but there is no action displayed. I will check the hue actions to confirm that they are not supported by UI but I believe you should not show the "Actions" if there is no supported thing actions. WDYT ?

image

@florian-h05
Copy link
Contributor Author

True.
I already check the length of the actions array, but I need to filter it for UI support first before doing that. Will create a PR for that.

@lolodomo
Copy link
Contributor

lolodomo commented Oct 27, 2024

Regarding the hue action, I can confirm it is not supported by UI because one of its input parameters is of type org.openhab.core.types.Command.

@florian-h05
Copy link
Contributor Author

My plan is that once war are finished with all core and UI changes around Thing actions that I write to the docs how to design a action for „good“ UI support.

florian-h05 added a commit that referenced this pull request Oct 27, 2024
…2839)

Fixes #2834 (comment).
Shows UI actions (currently only Z-Wave network map) with the Thing actions instead of the deprecated config actions.

Signed-off-by: Florian Hotze <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants