Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thing action popup: Multiple improvements #2840

Merged
merged 2 commits into from
Oct 27, 2024

Conversation

florian-h05
Copy link
Contributor

  • Default to action input name if no label provided
  • Use label for action output "result" if provided
  • Display action output descriptions if provided

- Default to action input name if no label provided
- Use label for action output "result" if provided
- Display action output descriptions if provided

Signed-off-by: Florian Hotze <[email protected]>
@florian-h05 florian-h05 added this to the 4.3 milestone Oct 27, 2024
@florian-h05 florian-h05 added the main ui Main UI label Oct 27, 2024
Copy link

relativeci bot commented Oct 27, 2024

#2434 Bundle Size — 10.85MiB (~+0.01%).

1124d28(current) vs deadfdb main#2432(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
#2434
     Baseline
#2432
No change  Initial JS 1.9MiB 1.9MiB
No change  Initial CSS 577.21KiB 577.21KiB
No change  Cache Invalidation 18.19% 18.19%
No change  Chunks 226 226
No change  Assets 249 249
No change  Modules 2938 2938
No change  Duplicate Modules 151 151
No change  Duplicate Code 1.88% 1.88%
No change  Packages 96 96
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2434
     Baseline
#2432
Regression  JS 9.06MiB (~+0.01%) 9.06MiB
No change  CSS 864.27KiB 864.27KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis reportBranch florian-h05:thing-actionsProject dashboard


Generated by RelativeCIDocumentationReport issue

Signed-off-by: Florian Hotze <[email protected]>
@florian-h05 florian-h05 merged commit 183f8f9 into openhab:main Oct 27, 2024
8 checks passed
@florian-h05 florian-h05 deleted the thing-actions branch October 27, 2024 14:52
@florian-h05 florian-h05 added the enhancement New feature or request label Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant