Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oh-label-card: Hide label if no label or Item configured #2874

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

florian-h05
Copy link
Contributor

This fixes an issue where "-" was displayed as label in that case, which was very annoying when using the label card only for displaying an icon.

This fixes an issue where "-" was displayed as label in that case,
which was very annoying when using the label card only for displaying an icon.

Signed-off-by: Florian Hotze <[email protected]>
@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Nov 16, 2024
@florian-h05 florian-h05 added this to the 4.3 milestone Nov 16, 2024
Copy link

relativeci bot commented Nov 16, 2024

#2488 Bundle Size — 10.87MiB (~+0.01%).

0e9fd10(current) vs 45dd117 main#2486(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change Regression 1 regression
                 Current
#2488
     Baseline
#2486
Regression  Initial JS 1.91MiB(~+0.01%) 1.91MiB
No change  Initial CSS 577.31KiB 577.31KiB
No change  Cache Invalidation 18.66% 18.66%
No change  Chunks 226 226
No change  Assets 249 249
No change  Modules 2940 2940
No change  Duplicate Modules 152 152
No change  Duplicate Code 1.8% 1.8%
No change  Packages 96 96
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2488
     Baseline
#2486
Regression  JS 9.08MiB (~+0.01%) 9.08MiB
No change  CSS 864KiB 864KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis reportBranch florian-h05:label-card-labelProject dashboard


Generated by RelativeCIDocumentationReport issue

@florian-h05 florian-h05 merged commit e3daf94 into openhab:main Nov 16, 2024
8 checks passed
@florian-h05 florian-h05 deleted the label-card-label branch November 16, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant