Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated oneAPI for 3.x branch #1817

Closed
wants to merge 1 commit into from
Closed

Conversation

jcsiadal
Copy link
Contributor

@jcsiadal jcsiadal commented May 5, 2023

Copy of commit for 2.x branch, plus removal of optional PSXE modules.
Module generation pre-check uses new compiler RPM.

Signed-off-by: jcsiadal <[email protected]>
@github-actions
Copy link

github-actions bot commented May 5, 2023

Test Results

  4 files  ±0    4 suites  ±0   0s ⏱️ ±0s
17 tests ±0  17 ✔️ ±0  0 💤 ±0  0 ±0 
18 runs  ±0  18 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit a3bc982. ± Comparison against base commit a17f649.

@adrianreber
Copy link
Member

I do not think introducing this much changes less than three weeks before the release is a good idea. Can you undo all the deletions and just bring over the version changes from the 2.x branch?

@jcsiadal
Copy link
Contributor Author

jcsiadal commented May 5, 2023

Actually, I think we should roll this into 2.x. PSXE is well past EOL. Do you want to schedule a short meeting to discuss?

@adrianreber
Copy link
Member

Actually, I think we should roll this into 2.x. PSXE is well past EOL. Do you want to schedule a short meeting to discuss?

For the releases targeted for SC 23 that sounds like a good idea, but not now.

Copy link

A friendly reminder that this PR had no activity for 30 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants