-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Regenerate modulefiles on update (fixes #1601) #1984
base: 3.x
Are you sure you want to change the base?
Conversation
2a3f6ef
to
bd44035
Compare
bd44035
to
f211c92
Compare
Signed-off-by: Orion Poplawski <[email protected]>
f211c92
to
cac80a4
Compare
Yes, for each OS there should be an RPM attached to the GitHub Actions. The RPMs are only kept for 24 hours however, previously we reached space limits keeping them for a longer time. Thanks for your PR. I will need at least one week before being able to look closer at this PR. |
I would like to run new shell scripts through shellcheck. We have a https://github.com/openhpc/ohpc/blob/3.x/tests/ci/Makefile which does that for us. Could you add the new shellscript to the shellcheck, whitespace and shfmt sections there. If you prefer to not do these changes I can also do them later. There is a similar script in the intel MPI compatibility package. I guess we should do the same changes there, right? |
Signed-off-by: Orion Poplawski <[email protected]>
Signed-off-by: Orion Poplawski <[email protected]>
79144f2
to
e221fee
Compare
Am I right that shmft want TAB characters for indentation? |
We just use the defaults that Just running |
A friendly reminder that this PR had no activity for 30 days. |
Any update on the PR? Still cannot upgrade oneAPI smoothly. |
This is as yet completely untested. But the idea is:
Does the CI generate rpms that can be tested?