-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix default network and DNS for compute nodes on Warewulf 4 #2053
Conversation
Hold on, something's not right with this PR/commit. |
41875e2
to
4e07e65
Compare
PR Fixed, something went wonky while rebasing against the latest 3.x. |
Test Results18 files - 6 18 suites - 6 27s ⏱️ -19s Results for commit 234dbbd. ± Comparison against base commit 1203424. This pull request removes 22 tests.
♻️ This comment has been updated with latest results. |
* Add netmask, gateway, and dns at the node profile level * Add internal_network, ipv4_gateway, dns_servers across input.local.template and inputs.tex Signed-off-by: Timothy Middelkoop <[email protected]>
4e07e65
to
234dbbd
Compare
Good eye. Fixes applied. I forced pushed this time since there were small changes, let me know if I should stick to delta's and squash a t the end. |
Force pushing is almost always the right solution from my point of view. Except you want to split commits for some reason. I would not push fixup commits to a PR. But that is just me. |
Add default networking to node profiles
* Add netmask, gateway, and dns at the node profile level
* Add internal_network, ipv4_gateway, dns_servers across
input.local.template and inputs.tex