Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default network and DNS for compute nodes on Warewulf 4 #2053

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

MiddelkoopT
Copy link
Contributor

Add default networking to node profiles
* Add netmask, gateway, and dns at the node profile level
* Add internal_network, ipv4_gateway, dns_servers across
input.local.template and inputs.tex

@MiddelkoopT
Copy link
Contributor Author

Hold on, something's not right with this PR/commit.

@MiddelkoopT
Copy link
Contributor Author

PR Fixed, something went wonky while rebasing against the latest 3.x.

Copy link

github-actions bot commented Nov 1, 2024

Test Results

18 files   -  6  18 suites   - 6   27s ⏱️ -19s
53 tests  - 22  49 ✅  - 22  4 💤 ±0  0 ❌ ±0 
66 runs   - 22  62 ✅  - 22  4 💤 ±0  0 ❌ ±0 

Results for commit 234dbbd. ± Comparison against base commit 1203424.

This pull request removes 22 tests.
rm_execution ‑ [libs/PHDF5] MPI C binary runs under resource manager (slurm/gnu14/mpich)
rm_execution ‑ [libs/PHDF5] MPI C binary runs under resource manager (slurm/gnu14/openmpi5)
rm_execution ‑ [libs/PHDF5] MPI C binary runs under resource manager (slurm/intel/mpich)
rm_execution ‑ [libs/PHDF5] MPI C binary runs under resource manager (slurm/intel/openmpi5)
rm_execution ‑ [libs/PHDF5] Parallel Fortran binary runs under resource manager (slurm/gnu14/mpich)
rm_execution ‑ [libs/PHDF5] Parallel Fortran binary runs under resource manager (slurm/gnu14/openmpi5)
rm_execution ‑ [libs/PHDF5] Parallel Fortran binary runs under resource manager (slurm/intel/mpich)
rm_execution ‑ [libs/PHDF5] Parallel Fortran binary runs under resource manager (slurm/intel/openmpi5)
test_module ‑ [HDF5] Verify HDF5 module is loaded and matches rpm version (gnu14)
test_module ‑ [HDF5] Verify HDF5 module is loaded and matches rpm version (intel)
…

♻️ This comment has been updated with latest results.

* Add netmask, gateway, and dns at the node profile level
* Add internal_network, ipv4_gateway, dns_servers across
  input.local.template and inputs.tex

Signed-off-by: Timothy Middelkoop <[email protected]>
@MiddelkoopT
Copy link
Contributor Author

Good eye. Fixes applied. I forced pushed this time since there were small changes, let me know if I should stick to delta's and squash a t the end.

@adrianreber
Copy link
Member

Force pushing is almost always the right solution from my point of view. Except you want to split commits for some reason. I would not push fixup commits to a PR. But that is just me.

@adrianreber adrianreber merged commit 8e2f91b into openhpc:3.x Nov 1, 2024
20 checks passed
@MiddelkoopT MiddelkoopT deleted the tm-warewulf4-network branch November 1, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants