Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenPiton Polara FPGA with plic #4

Open
wants to merge 23 commits into
base: openpiton_polara
Choose a base branch
from

Conversation

elisabethumblet
Copy link

This PR adds support for FPGA emulation of Polara. More specifically it adds the following:

  • Adding ALVEO U280 board as a target for FPGA implementation of Polara.

  • Adds timing and implementation constraint for Vivado synthesis.

  • Logic to instantiate top-level FPGA module for Openpiton framework.

  • Scripts for automating synthesis and implementation using Vivado in Openpiton framework.

Copy link

@hossein1387 hossein1387 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a few code style issues, everything looks good to me. I’ll wait for the confirmation that the ASIC flow passes before giving approval.

Comment on lines 36 to 45
// input mc_clk ,
// input mc_rstn ,
output logic chip_rstn ,
input logic chipset_clk ,
input logic chipset_rstn ,
output logic c0_init_calib_complete,

input logic [`NOC_DATA_WIDTH-1:0] mem_flit_in_data ,
input logic mem_flit_in_val ,
output logic mem_flit_in_rdy ,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove extra space.

logic fifo_trans_rdy;

logic [`AXI4_ID_WIDTH -1:0] m_axi_awid;
logic [`AXI4_ADDR_WIDTH -1:0] m_axi_awaddr;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove extra space.

Comment on lines +77 to +79
logic m_axi_awready;

logic [`AXI4_ID_WIDTH -1:0] m_axi_wid;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code formatting seems to be not consistent. Please review and remove extra space/tab and comments in the rest of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants