Define AXI as cva6 input parameters #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jean-Roch Coulon <[email protected]>
Signed-off-by: Jean-Roch Coulon <[email protected]>
Signed-off-by: Jean-Roch Coulon <[email protected]>
|
Can you please incorporate the changes I provided in my PR for the previous "noc" patch on the Thales fork? |
JeanRochCoulon
force-pushed
the
cvvdev/dev/params
branch
from
0b16829
to
c748dc6
Compare
|
Hello @Jbalkind I do not find out your changes in https://github.com/ThalesSiliconSecurity. Can you provide an URL ? |
|
You closed the issue when you deleted the previous branch: ThalesSiliconSecurity#1 |
|
❌ failed run, report available here. |
zarubaf
approved these changes
Jul 24, 2023
|
❌ failed run, report available here. |
|
@Jbalkind Your Fix has been integrated. I understood who was teh owner of ariane.flist file ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a part of AXI was defined in packages, now it is defined as cva6 input parameters
Signed-off-by: Jean-Roch Coulon [email protected]