Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Variant into CVA6 parameter #1320

Merged
merged 13 commits into from
Aug 22, 2023
Merged

Add Variant into CVA6 parameter #1320

merged 13 commits into from
Aug 22, 2023

Conversation

JeanRochCoulon
Copy link
Contributor

Signed-off-by: Jean-Roch Coulon [email protected]

@JeanRochCoulon
Copy link
Contributor Author

Hello @zarubaf @Jbalkind
This PR is not yet functional, but I would like to share it with you. As you can see the CVA6Cfg is composed of parameters related to User configuration, and "extended" which corresponds to parameters calculated from User parameters.
Cheers

@Jbalkind
Copy link
Contributor

This looks very exciting! Thank you for taking the time to chase this :)

@github-actions
Copy link
Contributor

❌ failed run, report available here.

@zarubaf
Copy link
Contributor

zarubaf commented Jul 26, 2023

Totally approve of this change!

@JeanRochCoulon
Copy link
Contributor Author

@zarubaf @Jbalkind Thank you for your enthusiasm. I will fix the PR to have everything pass at my holidays come back.

@github-actions
Copy link
Contributor

❌ failed run, report available here.

1 similar comment
@github-actions
Copy link
Contributor

❌ failed run, report available here.

@github-actions
Copy link
Contributor

❌ failed run, report available here.

@github-actions
Copy link
Contributor

❌ failed run, report available here.

@github-actions
Copy link
Contributor

✔️ successful run, report available here.

@JeanRochCoulon
Copy link
Contributor Author

@zarubaf the PR has been modified to :

  • fix the FPGA issue you get in your Merge CVA6Cfg and ArianeCfg #1321 PR. IsRVFI has been extracted from CVA6Cfg to allow a different configuration in FPGA case.
  • add the config_pkg to avoid duplication of CVA6Cfg type definition.

Can you approve and merge ?!? Then #1321 merge should be easier (I hope)

zarubaf
zarubaf approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@zarubaf zarubaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@zarubaf zarubaf merged commit 1db42ee into openhwgroup:master Aug 22, 2023
6 checks passed
JeanRochCoulon added a commit to openhwgroup/core-v-verif that referenced this pull request Aug 22, 2023
@JeanRochCoulon
Merge pull request #2080 from ThalesSiliconSecurity/cvvdev/dev/variant
2dc44c2 
Add variant into cva6 parameter
This PR is related to openhwgroup/cva6#1320
@JeanRochCoulon JeanRochCoulon deleted the cvvdev/dev/variant branch August 23, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zarubaf zarubaf zarubaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JeanRochCoulon @Jbalkind @zarubaf @cathales