Decode AMOXOR_D (and similar instructions) only when XLEN=64bits #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ failed run, report available here. |
AyoubJalali
reviewed
Aug 31, 2023
core/decoder.sv
Outdated
| @@ -1073,7 +1073,7 @@ module decoder import ariane_pkg::*; #( | |||
| instruction_o.rd[4:0] = instr.atype.rd; | |||
| // TODO(zarubaf): Ordering | |||
| // words | |||
| if (CVA6Cfg.RVA && instr.stype.funct3 == 3'h2) begin | |||
| if (riscv::IS_XLEN64 && CVA6Cfg.RVA && instr.stype.funct3 == 3'h2) begin | |||
There was a problem hiding this comment.
Hello @JeanRochCoulon, I think only the double words AMO.D instruction that should be decoded when XLEN = 64,
the AMO.W word instructions it a RV32A instruction.
So I think you should modify the condition for double words not words
JeanRochCoulon
changed the title
|
✔️ successful run, report available here. |
|
Thank you @AyoubJalali |
AyoubJalali
approved these changes
Sep 1, 2023
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes #1352