Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter overrides are not allowed for localparams #135

Closed
MikeOpenHWGroup opened this issue Jul 28, 2023 · 3 comments
Closed

Parameter overrides are not allowed for localparams #135

MikeOpenHWGroup opened this issue Jul 28, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@MikeOpenHWGroup
Copy link
Member

Bug Description

The top-level module cve2_top_tracing.sv attempts to override three localparam in cve2_top.sv:

  1. RV32B on line 123.
  2. DbgTriggerEn on line 124.
  3. DbgHwBreakNum on line 125.

This prevents the RTL model from compiling when cve2_top_tracing.sv is compiled as the top-level (as it is in the CORE-V-VERIF environment).

@MikeOpenHWGroup MikeOpenHWGroup added the bug Something isn't working label Jul 28, 2023
@LeeHoff
Copy link

LeeHoff commented Jul 28, 2023

this is fixed in my PR #132. Previously the cve2_top was instanced in core-v-verif/cv32e20/tb/uvmt/uvmt_cv32e20_dut_wrap, now when we instance cve2_top_tracing it needs the same parameters and I/O as cve2_top. This is the change in PR #132.

@MikeOpenHWGroup
Copy link
Member Author

Right you are @LeeHoff. In fact, that is exactly what you told me in a MM post. Mon bad.

#132 is now merged in an these errors have disappeared.

@LeeHoff
Copy link

LeeHoff commented Jul 28, 2023

@MikeOpenHWGroup It's good to have a bug created to say why things changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants