Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation and Linux Makefile improvements #1023

Merged

Conversation

jordancarlin
Copy link
Member

CI

  • Add custom user level installation to CI
  • Ensure installation CI logs are always uploaded if installation fails

Installation

  • Don't suggest looking in the log file if it doesn't exist + log more installation
  • Refactor helper functions for increased readability and maintainability
  • Update download methods (git and wget/curl) for increased robustness with transient network issues (sometimes experienced by GitHub Actions runners)

Linux Makefile

  • Remove old cleanDriver rule
  • Add environment variable validation to ensure setup.sh has been sourced or make is run by installation script (@stineje this address what we were discussing)

@jordancarlin
Copy link
Member Author

The CI failure for Ubuntu 20.04 is due to an upstream change that broke compatibility with old GCC unrelated to these changes. I’ve opened a PR to fix it. All other CI tests are passing.

@davidharrishmc davidharrishmc merged commit 4efe67d into openhwgroup:main Oct 22, 2024
10 of 11 checks passed
@jordancarlin jordancarlin deleted the installation_improvements branch October 22, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants