Add support for a credential denial error #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decentralgabe
requested review from
Sakurann,
tlodderstedt and
selfissued
and removed request for
Sakurann and
tlodderstedt
|
why would an issuer deny a credential request without giving the wallet any reason? does not sound like a good user experience. |
Why wouldn't they give a reason? That's what the |
jogu
approved these changes
May 16, 2024
selfissued
approved these changes
May 16, 2024
peppelinux
reviewed
May 16, 2024
peppelinux
approved these changes
May 16, 2024
Co-authored-by: Giuseppe De Marco <[email protected]>
paulbastian
reviewed
May 16, 2024
decentralgabe
commented
May 16, 2024
paulbastian
approved these changes
May 16, 2024
awoie
approved these changes
May 17, 2024
tplooker
approved these changes
May 19, 2024
Sakurann
reviewed
May 24, 2024
Sakurann
reviewed
May 24, 2024
| @@ -1007,7 +1007,7 @@ If the Credential Request does not contain an Access Token that enables issuance | |||
|
|
|||
| #### Credential Request Errors {#credential-request-errors} | |||
|
|
|||
| For the errors specific to the payload of the Credential Request such as those caused by `type`, `format`, `proof`, or encryption parameters in the request, the error codes values defined in this section MUST be used instead of a generic `invalid_request` parameter defined in Section 3.1 of [@!RFC6750]. | |||
| For errors related to the Credential Request's payload, such as issues with `type`, `format`, `proof`, encryption parameters, or if the request is denied, use the specific error codes from this section MUST be used instead of the generic `invalid_request` parameter defined in Section 3.1 of [@!RFC6750]. | |||
There was a problem hiding this comment.
are the purpose of these changes clarification or do they have implication on the introduction of this new error code?
There was a problem hiding this comment.
I do believe there's some implications since I'm not sure how implementers have represented such errors today (before this change)
Co-authored-by: Kristina <[email protected]>
Sakurann
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec currently does not handle the case where an issuer says "cool request bro, but no"
This text supports an issuer's right to deny a credential request for whatever reason, unrelated to the validity of the request itself