Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added more examples illustrating the use of Authorization Servers (AS) and Resource Servers (RS) in this specification #322

Merged
merged 5 commits into from
Jun 18, 2024

Conversation

peppelinux
Copy link
Member

this PR is merely editorial and aims to resolve the issue #311

…ers (AS) and Resource Servers (RS) in this specification.
openid-4-verifiable-credential-issuance-1_0.md Outdated Show resolved Hide resolved
@jogu
Copy link
Contributor

jogu commented May 29, 2024

Discussed on today's WG call:

  1. There was a consensus that splitting the credential issuer & the AS in the diagrams is a good idea
  2. However we felt that the credential issuer should be to the right of the authorization server, as in most oauth sequence diagrams the resource server is shown on the right hand side of the authorization server and it was felt it would help people's mental models if we followed that convention.
  3. If we're going to add AS to this diagram, then we should add it to all diagrams (I think there's only one other diagram)

Copy link
Contributor

@jogu jogu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per my above comment

@peppelinux
Copy link
Member Author

I can do that during the next week, thank you for the feedback

@peppelinux
Copy link
Member Author

@jogu I did the requested changes here: 0521a83

@Sakurann Sakurann requested a review from jogu June 17, 2024 21:06
Copy link
Collaborator

@Sakurann Sakurann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, Giuseppe!

@jogu jogu merged commit 1e2c0ed into main Jun 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants