Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add randomness to the credential_offer_uri #336

Merged
merged 3 commits into from
Jun 12, 2024
Merged

Conversation

Sakurann
Copy link
Collaborator

resolves #295 as suggested in the issue comment

Copy link
Contributor

@paulbastian paulbastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved regarding the outstanding suggestions

@TakahikoKawasaki
Copy link

FYI: A real-world example showing two QR codes representing the same credential offer, one by value and the other by reference.

credential_offer_by_value_and_reference

@Sakurann Sakurann requested a review from javereec June 8, 2024 19:59
@Sakurann Sakurann merged commit 4148498 into main Jun 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.1.3 examples are non consistent
6 participants