Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guidance on format identifiers; fixes #173 #351

Merged
merged 4 commits into from
Jul 4, 2024
Merged

Add guidance on format identifiers; fixes #173 #351

merged 4 commits into from
Jul 4, 2024

Conversation

awoie
Copy link
Contributor

@awoie awoie commented Jun 18, 2024

This PR does the following:

  • Fixes Why for the mdoc cbor the format identifier is mso_mdoc? #173
  • Fixes typo in credential format appendix intro section.
  • Adds guidance on choosing format identifiers for new credential format profiles.
  • Harmonized capitalization of Credential Format, Credential Format Identifier, Credential Format Profile and related hyphens

Co-authored-by: Giuseppe De Marco <[email protected]>
Co-authored-by: Giuseppe De Marco <[email protected]>
@jogu
Copy link
Contributor

jogu commented Jul 4, 2024

At least 3 reviews, open for at least a week, no unresolved comments - merging! Thanks Oliver!

@jogu jogu merged commit 32fdeff into main Jul 4, 2024
2 checks passed
@jogu jogu deleted the awoie/fix-173 branch July 4, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why for the mdoc cbor the format identifier is mso_mdoc?
7 participants