gh-18: removes the Batch Credential Endpoint #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jogu
approved these changes
Jul 16, 2024
pmhsfelix
changed the title
peppelinux
reviewed
Jul 17, 2024
peppelinux
reviewed
Jul 17, 2024
peppelinux
reviewed
Jul 17, 2024
peppelinux
reviewed
Jul 17, 2024
peppelinux
reviewed
Jul 17, 2024
peppelinux
reviewed
Jul 17, 2024
peppelinux
reviewed
Jul 17, 2024
peppelinux
reviewed
Jul 17, 2024
peppelinux
reviewed
Jul 17, 2024
peppelinux
approved these changes
Jul 17, 2024
Sakurann
reviewed
Jul 18, 2024
Sakurann
reviewed
Jul 18, 2024
Sakurann
reviewed
Jul 18, 2024
Sakurann
reviewed
Jul 18, 2024
babisRoutis
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
There are several proposed updates to the initial PR content that haven't been addressed.
IMO, all proposals make sense, yet I am not sure who should resolve them. Probably, @pmhsfelix
Anyway, assuming that the changes will find their way to the text, I think that it is ready.
Removes "multiple" Co-authored-by: Joseph Heenan <[email protected]>
Co-authored-by: Joseph Heenan <[email protected]>
Co-authored-by: Joseph Heenan <[email protected]>
Co-authored-by: Giuseppe De Marco <[email protected]>
Co-authored-by: Giuseppe De Marco <[email protected]>
Co-authored-by: Giuseppe De Marco <[email protected]>
Co-authored-by: Giuseppe De Marco <[email protected]>
Co-authored-by: Giuseppe De Marco <[email protected]>
Co-authored-by: Kristina <[email protected]> Co-authored-by: Giuseppe De Marco <[email protected]>
|
Thanks @pmhsfelix - I've rereviewed the latest changes and they look good to me and I believe resolve all comments in a sensible manner. We have 3 approvals, got wide consensus on the grouping calls & mailing list for this change, and it's been open over a week and I believe has resolved all comments in a sensible manner so merging! |
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the Batch Credential Endpoint, following the discussion and decisions in #18.
closes #18
@jogu pointed out that this would close some other issues too, probably one of these: https://github.com/openid/OpenID4VCI/issues?q=is%3Aissue+is%3Aopen+label%3Abatch-deferred