Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet notifying the Issuer of (un)successful issuance of credential(s) #70

Merged
merged 61 commits into from
Dec 22, 2023
Merged

Wallet notifying the Issuer of (un)successful issuance of credential(s) #70

Changes from 58 commits
Commits
Show all changes
61 commits
Select commit Hold shift + click to select a range
2d05938
migrate PR608 from bitbucket
Sep 7, 2023
dd001bf
Apply suggestions from code review
Sakurann Sep 28, 2023
0f50200
modify issuer_state
Sep 29, 2023
f4159a5
Apply suggestions from Giuseppe's code review
Sakurann Sep 29, 2023
789280f
Apply suggestions from Giuseppe's code review
Sakurann Sep 29, 2023
ec74329
add callback_id
Sep 29, 2023
c412351
pull from remote
Sep 29, 2023
f8199af
align batch to credential endpoint
Sep 29, 2023
2e49036
Merge branch 'main' of https://github.com/openid/OpenID4VCI into wall…
Sep 29, 2023
a9b395a
Apply suggestions from code review
Sakurann Sep 29, 2023
28ef6d5
Revert "modify issuer_state"
Sep 29, 2023
43ab8c5
Merge branch 'wallet-callback' of https://github.com/openid/OpenID4VC…
Sep 29, 2023
832d02e
typo
Sakurann Sep 30, 2023
3072d9a
remove issuer_state
Sakurann Oct 2, 2023
33883e9
change status values to success, failure and rejected
Sakurann Oct 2, 2023
80e0925
callback endpoint is protected by the AT
Oct 4, 2023
2d3a8ba
Cla
Sakurann Oct 4, 2023
b9f78cc
add section on successful and error responses
Oct 4, 2023
0fe3bcd
resolve merge conflict
Oct 4, 2023
c8abe73
typos
Sakurann Oct 5, 2023
ae5cafe
capitalize Credential
Sakurann Oct 5, 2023
2acd3f0
removing media type requirements
Sakurann Oct 5, 2023
e817440
clarify three `status` values
Sakurann Oct 5, 2023
61a822a
change example to 204 No Content
Sakurann Oct 5, 2023
0c579cc
clean-up of the intro text
Sakurann Oct 5, 2023
f61190d
updating example to be access token authentication
Sakurann Oct 10, 2023
03590bd
Apply wording based on the suggestions from code review
Sakurann Oct 25, 2023
535af99
Merge branch 'main' of https://github.com/openid/OpenID4VCI into wall…
Oct 26, 2023
8d45c70
draft PR on how callback_session could work
Oct 26, 2023
7cdd683
Revert "draft PR on how callback_session could work"
Oct 26, 2023
d47ac70
resolve merge conflicts
Nov 16, 2023
baee859
replace callback with acknowledgement
Nov 16, 2023
ff44971
removes a surplus `
Sakurann Nov 22, 2023
1deaab6
clean up
Sakurann Nov 23, 2023
2ff050e
Apply suggestions from code review
Sakurann Nov 30, 2023
0dac2ce
Apply suggestions from code review
Sakurann Dec 11, 2023
a3cb647
resolve merge conflicts
Dec 12, 2023
90d2da7
fix error message
Dec 12, 2023
d51c053
change to delete signal and make this endpoint optional to the wallet
Sakurann Dec 13, 2023
7d56d73
Apply suggestions from Torsten's code review
Sakurann Dec 13, 2023
60fdf99
rename issuer metadata to ack_endpoint
Sakurann Dec 13, 2023
f28c7fc
clarify error behavior
Sakurann Dec 14, 2023
d6f83fe
fix merge conflicts
Dec 18, 2023
dfc43a8
fix references
Dec 18, 2023
2497a0b
change from acknowledgement to notification
Dec 18, 2023
6a28ceb
editorial
Dec 18, 2023
6dd2602
The Wallet MUST send one Notification Request per Credential issued
Dec 18, 2023
3151a41
update language
tplooker Dec 19, 2023
f40e6fe
Update openid-4-verifiable-credential-issuance-1_0.md
tplooker Dec 19, 2023
1032ceb
Update openid-4-verifiable-credential-issuance-1_0.md
tplooker Dec 19, 2023
50ec2b4
Apply suggestions from code review
Sakurann Dec 21, 2023
6943429
Merge branch 'main' into wallet-callback
Sakurann Dec 21, 2023
458ab77
add document history
Dec 21, 2023
43f9cfc
Merge branch 'wallet-callback' of https://github.com/openid/OpenID4VC…
Dec 21, 2023
4d95136
fix typo to make file compile
Dec 21, 2023
f3a0d7b
Apply suggestions from code review
Sakurann Dec 21, 2023
1ffd4d9
Apply suggestions from code review
Sakurann Dec 21, 2023
33a451c
networking error can cause request not received
Sakurann Dec 21, 2023
fe4892d
clarify this endpoint is optional for the wallet
Sakurann Dec 22, 2023
b9caf63
Merge branch 'main' into wallet-callback
Sakurann Dec 22, 2023
3085621
Merge branch 'main' into wallet-callback
Sakurann Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading