Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed draft name and added revision number #80

Merged
merged 23 commits into from
Jan 9, 2024
Merged

Conversation

tlodderstedt
Copy link
Contributor

No description provided.

Copy link
Member

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add " - draft 00" to the title line so we can publish to openid.net/specs/ after adoption and add a History section with a history entry for 00. Thanks.

@tlodderstedt
Copy link
Contributor Author

Please add " - draft 00" to the title line so we can publish to openid.net/specs/ after adoption and add a History section with a history entry for 00. Thanks.

it already has draft in the title

@selfissued
Copy link
Member

The title is currently "OpenID4VC High Assurance Interoperability Profile with SD-JWT VC". Please change this to "OpenID4VC High Assurance Interoperability Profile with SD-JWT VC - draft 00".

@selfissued
Copy link
Member

Also, please add the "Notices" appendix like the one at https://openid.net/specs/openid-4-verifiable-credential-issuance-1_0-12.html#name-notices and an "Acknowledgements" appendix.

@tlodderstedt
Copy link
Contributor Author

The title is currently "OpenID4VC High Assurance Interoperability Profile with SD-JWT VC". Please change this to "OpenID4VC High Assurance Interoperability Profile with SD-JWT VC - draft 00".

image

@selfissued
Copy link
Member

The checklist of OpenID spec contents is at https://openid.net/wg/resources/naming-and-contents-of-specifications/.

@selfissued
Copy link
Member

Finally, before we publish to openid.net/specs/, I propose that we update the pathname to align with other specs in the family. The pathname is currently oid4vc-haip-sd-jwt-vc. To me, the logical pathname would be openid-4-verifiable-credential-haip-sd-jwt-vc-1_0 or (shorter) openid-4-vc-haip-sd-jwt-vc-1_0. Those are more like openid-4-verifiable-credential-issuance-1_0, for instance. Thanks.

(I particularly think that we need to change "oid", as OID means Object Identifier to most people in the identity space, as used in X.509, and doesn't incorporate the usual openid branding.)

@tlodderstedt
Copy link
Contributor Author

Also, please add the "Notices" appendix like the one at https://openid.net/specs/openid-4-verifiable-credential-issuance-1_0-12.html#name-notices and an "Acknowledgements" appendix.

done

@tlodderstedt
Copy link
Contributor Author

Finally, before we publish to openid.net/specs/, I propose that we update the pathname to align with other specs in the family. The pathname is currently oid4vc-haip-sd-jwt-vc. To me, the logical pathname would be openid-4-verifiable-credential-haip-sd-jwt-vc-1_0 or (shorter) openid-4-vc-haip-sd-jwt-vc-1_0. Those are more like openid-4-verifiable-credential-issuance-1_0, for instance. Thanks.

(I particularly think that we need to change "oid", as OID means Object Identifier to most people in the identity space, as used in X.509, and doesn't incorporate the usual openid branding.)

We use oid4vc as acronym for the protocol family for quite some time now. If we want to be more verbose, I would rather resolve haip into high-assurance-interoperability-profile -> oid4vc-high-assurance-interoperability-profile-sd-jwt-vc-1_0
@Sakurann WDYT?

@selfissued
Copy link
Member

Essentially all of the specs at openid.net/specs/ begin with "openid-". (The exceptions are those that start with "fapi-" and "oauth-".) Given that this is an OpenID spec, we should start the path with "openid-". I'd be fine with openid-high-assurance-interoperability-profile-sd-jwt-vc-1_0, for instance.

Consistency matters.

@Sakurann
Copy link
Contributor

Sakurann commented Jan 2, 2024

I would be ok with openid4vc-high-assurance-interoperability-profile-sd-jwt-vc-1_0. (Would prefer it over openid4vc-haip-sd-jwt-vc-1_0).

Just openid- is not accurate/sufficient and expanding openid-4-verifiable-credentials does not really make sense in HAIP context.

@tlodderstedt
Copy link
Contributor Author

@selfissued I changed the file name to openid4vc-high-assurance-interoperability-profile-sd-jwt-vc-1_0. Can you please approve the PR now?

Copy link
Member

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Torsten


# Notices

Copyright (c) 2023 The OpenID Foundation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Copyright (c) 2023 The OpenID Foundation.
Copyright (c) 2024 The OpenID Foundation.

@tlodderstedt tlodderstedt merged commit 07ef216 into main Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants