Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sd-jwt vc profile from HAIP because it was moved to VCI #96

Merged
merged 1 commit into from
May 24, 2024

Conversation

Sakurann
Copy link
Contributor

@Sakurann Sakurann commented Mar 20, 2024

closes #95

Copy link
Contributor

@jogu jogu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but we probably shouldn't merge it until the version of VP that is linked to actually contains the SD JWT VC profile :) (which I think means finishing the VP PR and publishing a numbered draft).

@javereec
Copy link

Suggest to also correctly reference the Key Binding JWT (KB JWT) in the section on "Crypto Suites", now it says HB JWT, which I think references the KB JWT from the IETF SD-JWT VC spec.

@Sakurann Sakurann merged commit b0f6b6e into main May 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Credential request parameters for IETF SD-JWT VCs on this profile seem inconsistent with OID4VCI's
5 participants