Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-normative issues #195

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix non-normative issues #195

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee796c2
Fix non-normative issues
FragLegs Aug 12, 2024
8d25a6c
Move note
FragLegs Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions openid-sharedsignals-framework-1_0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,10 +592,12 @@ default_subjects
> OPTIONAL. A string indicating the default behavior of newly created streams. If present,
the value MUST be either "ALL" or "NONE". If not provided, the Transmitter behavior in
this regard is unspecified.

> - "ALL" indicates that any subjects that are appropriate for the stream are added to
the stream by default. The Receiver MAY remove subjects from the stream via the
`remove_subject_endpoint`, causing events for those subjects to _not_ be transmitted.
The Receiver MAY re-add any subjects removed this way via the `add_subject_endpoint`.

> - "NONE" indicates that no subjects are added by default. The Receiver MAY add subjects
to the stream via the `add_subject_endpoint`, causing only events for those subjects
to be transmitted. The Receiver MAY remove subjects added this way via the
Expand Down Expand Up @@ -949,13 +951,14 @@ The HTTP POST request MAY contain the Receiver-Supplied values of the Stream
Configuration ({{stream-config}}) object:

* `events_requested`
* `delivery` : Note that in the case of the poll method, the `endpoint_url` value is
supplied by the Transmitter.
* `delivery`
* `description`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line looks strange. Should there be an explanation after this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should not have an explanation, but I can move the note that is attached to delivery so that it is below the list.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is a normative change. Any reason to think of this as a non-normative change?


If the request does not contain the `delivery` property, then the Transmitter
MUST assume that the `method` is "urn:ietf:rfc:8936" (poll). The
Transmitter MUST include a `delivery` property in the response with this
`method` property and an `endpoint_url` property.
`method` property and an `endpoint_url` property. Note that in the case of the poll
method, the `endpoint_url` value is supplied by the Transmitter.

The following is a non-normative example request to create an Event Stream:

Expand Down
Loading