8339475: Clean up return code handling for pthread calls in library coding

[MBaesken]

Backport 8339475, includes 8341135

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8339475 needs maintainer approval
• JDK-8341135 needs maintainer approval

Issues

• JDK-8339475: Clean up return code handling for pthread calls in library coding (Bug - P4 - Requested)
• JDK-8341135: Incorrect format string after JDK-8339475 (Bug - P3 - Requested)

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/184/head:pull/184
$ git checkout pull/184

Update a local copy of the PR:
$ git checkout pull/184
$ git pull https://git.openjdk.org/jdk23u.git pull/184/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 184

View PR using the GUI difftool:
$ git pr show -t 184

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/184.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[MBaesken]

/help

[openjdk]

@MBaesken Available commands:

• approval - request for maintainer's approval
• approve - null
• author - sets an overriding author to be used in the commit when the PR is integrated
• backport - create a backport
• cc - add or remove an additional classification label
• clean - Mark the backport pull request as a clean backport
• contributor - adds or removes additional contributors for a PR
• covered - used when employer has signed the OCA
• csr - require a compatibility and specification request (CSR) for this pull request
• help - shows this text
• integrate - performs integration of the changes in the PR
• issue - edit the list of issues that this PR solves
• jep - require a JDK Enhancement Proposal (JEP) for this pull request
• label - add or remove an additional classification label
• open - Set the pull request state to "open"
• reviewer - manage additional reviewers for a PR
• reviewers - set the number of additional required reviewers for this PR
• signed - used after signing the OCA
• solves - edit the list of issues that this PR solves
• sponsor - performs integration of a PR that is authored by a non-committer
• summary - updates the summary in the commit message
• test - used to run tests

[MBaesken]

/issue add JDK-8341135

[openjdk]

@MBaesken
Adding additional issue to issue list: 8341135: Incorrect format string after JDK-8339475.

[mlbridge]

Webrevs

• 00: Full (4288f90d)

[TheRealMDoerr]

It contains one small part of openjdk/jdk@8ea6adc in splashscreen_sys.c. Ok.

[openjdk]

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[bridgekeeper]

@MBaesken This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!