Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8341722: Fix some warnings as errors when building on Linux with toolchain clang #213

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

8341722: Fix some warnings as errors when building on Linux with toolchain clang #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/jdk.hotspot.agent/linux/native/libsaproc/LinuxDebuggerLocal.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,6 @@ JNIEXPORT jlongArray JNICALL Java_sun_jvm_hotspot_debugger_linux_LinuxDebuggerLo
jboolean isCopy;
jlongArray array;
jlong *regs;
int i;

struct ps_prochandle* ph = get_proc_handle(env, this_obj);
if (get_lwp_regs(ph, lwp_id, &gregs) != true) {
Expand Down
4 changes: 2 additions & 2 deletions src/jdk.hotspot.agent/linux/native/libsaproc/symtab.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,6 @@ static struct symtab* build_symtab_internal(int fd, const char *filename, bool t

if (shdr->sh_type == sym_section) {
ELF_SYM *syms;
int rslt;
size_t size, n, j, htab_sz;

// FIXME: there could be multiple data buffers associated with the
Expand Down Expand Up @@ -390,7 +389,8 @@ static struct symtab* build_symtab_internal(int fd, const char *filename, bool t
goto bad;
}

rslt = hcreate_r(htab_sz, symtab->hash_table);
// int rslt =
hcreate_r(htab_sz, symtab->hash_table);
// guarantee(rslt, "unexpected failure: hcreate_r");

// shdr->sh_link points to the section that contains the actual strings
Expand Down
4 changes: 0 additions & 4 deletions src/jdk.jpackage/share/native/common/Log.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,6 @@ namespace {
// variables are initialized if any. This will result in AV. To avoid such
// use cases keep logging module free from static variables that require
// initialization with functions called by CRT.
//

// by default log everything
const Logger::LogLevel defaultLogLevel = Logger::LOG_TRACE;

char defaultLogAppenderMemory[sizeof(StreamLogAppender)] = {};

Expand Down
4 changes: 2 additions & 2 deletions test/hotspot/gtest/runtime/test_os_linux.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,10 +360,10 @@ TEST_VM(os_linux, pretouch_thp_and_use_concurrent) {
EXPECT_TRUE(os::commit_memory(heap, size, false));

{
auto pretouch = [heap, size](Thread*, int) {
auto pretouch = [heap](Thread*, int) {
os::pretouch_memory(heap, heap + size, os::vm_page_size());
};
auto useMemory = [heap, size](Thread*, int) {
auto useMemory = [heap](Thread*, int) {
int* iptr = reinterpret_cast<int*>(heap);
for (int i = 0; i < 1000; i++) *iptr++ = i;
};
Expand Down