Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8337410: The makefiles should set problemlist and adjust timeout basing on the given VM flags #216

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Nov 6, 2024

Hi all,

This pull request contains a backport of commit 5e021cbc from the openjdk/jdk repository.

The commit being backported was authored by Leonid Mesnik on 7 Aug 2024 and was reviewed by Magnus Ihse Bursie.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8337410 needs maintainer approval

Issue

  • JDK-8337410: The makefiles should set problemlist and adjust timeout basing on the given VM flags (Enhancement - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/216/head:pull/216
$ git checkout pull/216

Update a local copy of the PR:
$ git checkout pull/216
$ git pull https://git.openjdk.org/jdk23u.git pull/216/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 216

View PR using the GUI difftool:
$ git pr show -t 216

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/216.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 6, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 6, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 5e021cbcc7a6cb30a27380950e115ff12846239c 8337410: The makefiles should set problemlist and adjust timeout basing on the given VM flags Nov 6, 2024
@openjdk
Copy link

openjdk bot commented Nov 6, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 6, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 6, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 6, 2024

Webrevs

@sendaoYan
Copy link
Member Author

/approval request Clean backport to make jtreg makefile set problemlist and adjust timeout basing on the given VM flags.

@openjdk
Copy link

openjdk bot commented Nov 14, 2024

@sendaoYan
8337410: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Nov 14, 2024
@openjdk
Copy link

openjdk bot commented Nov 15, 2024

@sendaoYan This pull request has not yet been marked as ready for integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant