Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8261: Use test flag to skip JDP multicast tests in JolokiaTest #588

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

8261: Use test flag to skip JDP multicast tests in JolokiaTest #588

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f8dd61
Try to use new test flag to decide whether multicast is supported
skarsaune Sep 11, 2024
5b20ff6
Merge remote-tracking branch 'origin/master' into use_new_test_flag_t…
skarsaune Nov 1, 2024
89e34aa
JMC-8261: Spotless fix
skarsaune Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions ...tests/org.openjdk.jmc.jolokia.test/src/test/java/org/openjdk/jmc/jolokia/JolokiaTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,11 +159,8 @@ private static MBeanServerConnection getJolokiaMBeanConnector() throws IOExcepti

@Test
public void testDiscover() {
boolean isMacOs = "macosx".equals(System.getProperty("osgi.os"));
boolean isCiRun = "true".equals(System.getenv("GITHUB_ACTIONS"));
boolean shouldTestMacOS = "true".equals(System.getenv("JOLOKIA_TEST_DISCOVERY_ON_MAC"));
if (isMacOs && isCiRun && !shouldTestMacOS) {
//This does not work in the JMC CI pipeline for Mac
if ("true".equals(System.getProperty("skipJDPMulticastTests"))) {
//In certain situations multicast will not work
// 'D> --> Couldnt send discovery message from /127.0.0.1: java.net.BindException: Can't assign requested address
// D> --> Exception during lookup: java.util.concurrent.ExecutionException:
// org.jolokia.service.discovery.MulticastUtil$CouldntSendDiscoveryPacketException:
Expand Down