8276: UI tests failing on Windows

[thegreystone]

Ignoring failing tests for now.

---

Progress

• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JMC-8276: UI tests failing on Windows (Bug - P2)

Reviewers

• Alex Macdonald (@aptmac - Reviewer)
• Virag Purnam (@viragpurnam - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/594/head:pull/594
$ git checkout pull/594

Update a local copy of the PR:
$ git checkout pull/594
$ git pull https://git.openjdk.org/jmc.git pull/594/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 594

View PR using the GUI difftool:
$ git pr show -t 594

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/594.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@thegreystone This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276: UI tests failing on Windows

Reviewed-by: aptmac, vpurnam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (c804eb04)

[aptmac]

Interesting that those tests are failing, as the main fix was merged into JDK 19 and then backported to 17 (which is where I tested and un-ignored the tests).

At the moment my Windows setup is not having a fun time with Jemmy so I'll try to fix my local workspace and try again soon.

[aptmac]

Edit: Nevermind, I had it backwards. Disregard this comment.

JDK-8286740 was the backport, now that we're on JDK 21 the correct issue would be: https://bugs.openjdk.org/browse/JDK-8328159

[aptmac]

I'm seeing this on my Linux machine (my Windows builds are still on fire), so the ignore statements can be updated to be non-specific to Windows. Will have to take a look at what is going on another time.

[viragpurnam]

LGTM.
Branch "8276-ui-tests" has been created directly to "openjdk/jmc" and not on forked repo. After merging, this branch needs to be deleted.

[aptmac]

Not sure what's going on with the checks here, but it's only showing the one jcheck for me, similar to #588.

Wonder what happened to the other CI actions.

[viragpurnam]

Not sure what's going on with the checks here, but it's only showing the one jcheck for me, similar to #588.

Wonder what happened to the other CI actions.

@aptmac: Other jcheck only runs on forked repo. As this branch is directly on main repo, other jcheck is missing.

[aptmac]

Not sure what's going on with the checks here, but it's only showing the one jcheck for me, similar to #588.
Wonder what happened to the other CI actions.

@aptmac: Other jcheck only runs on forked repo. As this branch is directly on main repo, other jcheck is missing.

Interesting, thanks for the info. Would you happen to know why they didn't run on this PR then? #588

[viragpurnam]

I think "Martin Skarsaune" has not enabled the workflow run in his forked repo.

[aptmac]

I think "Martin Skarsaune" has not enabled the workflow run in his forked repo.

That might be it, I'll have to poke around a bit more. His first handful of PRs did all the workflows, but his current actions seem to be stuck on a workflow dependency that is failing for a reason not obvious to me.

[viragpurnam]

Oh ok. I will see the log and try.

[thegreystone]

/integrate

[openjdk]

Going to push as commit 9e3bbaa.

[openjdk]

@thegreystone Pushed as commit 9e3bbaa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.