Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable spotbugs check that fails on Mac OS in CI #603

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

skarsaune
Copy link
Contributor

@skarsaune skarsaune commented Nov 1, 2024


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Error

 ⚠️ The pull request body must not be empty.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/603/head:pull/603
$ git checkout pull/603

Update a local copy of the PR:
$ git checkout pull/603
$ git pull https://git.openjdk.org/jmc.git pull/603/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 603

View PR using the GUI difftool:
$ git pr show -t 603

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/603.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 1, 2024

👋 Welcome back skarsaune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@@ -1336,6 +1336,11 @@
<Method name="createFlameGraph"/>
<Bug pattern="NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE"/>
</Match>
<Match>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Covered by the comment just above.

@openjdk
Copy link

openjdk bot commented Nov 1, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@thegreystone
Copy link
Member

I think this was fixed by #598. At least the CI runs were fine in that PR and in subsequent PRs, e.g. #599.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants