-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataset object for v1 #135
Conversation
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4.6.1 to 4.7.0. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v4.6.1...v4.7.0) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…/actions/setup-python-4.7.0 Bump actions/setup-python from 4.6.1 to 4.7.0
Auto-update pre-commit hooks
…et can now follow symlinks. Updated tests, and install ASE at test time for Dataset-ase loader tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ipcamit I've left some comments. Would be happy to discuss them.
Pushing new changes as per suggestions:
On new dataset initialization: The main difference between |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ipcamit. The updates look great. I just have a few minor comments. After this, I think we should be able to merge it.
Summary
Include a summary of major changes in bullet points:
Additional dependencies introduced (if any)