-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: JobSidecarTerminator support exec sidecar preStop #1506
feat: JobSidecarTerminator support exec sidecar preStop #1506
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d25c5de
to
64c7aba
Compare
@hantmac You first resolve the ci, https://github.com/openkruise/kruise/actions/runs/7959327463/job/21726086668?pr=1506 |
Signed-off-by: hantmac <[email protected]>
Signed-off-by: hantmac <[email protected]>
fff2acb
to
fd2b40a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1506 +/- ##
==========================================
+ Coverage 48.55% 48.66% +0.10%
==========================================
Files 157 157
Lines 22480 22496 +16
==========================================
+ Hits 10916 10948 +32
+ Misses 10360 10348 -12
+ Partials 1204 1200 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks! UT fixed. |
/hold |
@hantmac: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Ⅰ. Describe what this PR does
Fix #1486
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews