Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: JobSidecarTerminator support exec sidecar preStop #1506

Conversation

hantmac
Copy link
Member

@hantmac hantmac commented Feb 19, 2024

Ⅰ. Describe what this PR does

Fix #1486

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zmberg for approval by writing /assign @zmberg in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot added the size/M size/M: 30-99 label Feb 19, 2024
@hantmac hantmac force-pushed the feat/JobSidecarTerminator-exec-prestop branch from d25c5de to 64c7aba Compare February 19, 2024 12:13
@zmberg
Copy link
Member

zmberg commented Feb 20, 2024

@hantmac hantmac force-pushed the feat/JobSidecarTerminator-exec-prestop branch from fff2acb to fd2b40a Compare February 20, 2024 08:29
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.66%. Comparing base (5421ee7) to head (fd2b40a).
Report is 64 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1506      +/-   ##
==========================================
+ Coverage   48.55%   48.66%   +0.10%     
==========================================
  Files         157      157              
  Lines       22480    22496      +16     
==========================================
+ Hits        10916    10948      +32     
+ Misses      10360    10348      -12     
+ Partials     1204     1200       -4     
Flag Coverage Δ
unittests 48.66% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hantmac
Copy link
Member Author

hantmac commented Feb 20, 2024

@zmberg zmberg modified the milestones: v1.5, 1.6 Mar 7, 2024
@zmberg
Copy link
Member

zmberg commented Mar 8, 2024

/hold

@zmberg zmberg removed this from the 1.6 milestone Mar 8, 2024
@kruise-bot
Copy link

@hantmac: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

stale bot commented Jun 12, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jun 12, 2024
@stale stale bot closed this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold needs-rebase size/M size/M: 30-99 wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] JobSidecarTerminator support exec sidecar preStop bash
3 participants