Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix e2e and limit workflow action permission #1523

Merged
merged 1 commit into from
Mar 18, 2024
Merged

fix e2e and limit workflow action permission #1523

merged 1 commit into from
Mar 18, 2024

Conversation

furykerry
Copy link
Member

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot kruise-bot added the size/XS size/XS: 0-9 label Mar 14, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.87%. Comparing base (c33088b) to head (1ac3955).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1523      +/-   ##
==========================================
- Coverage   47.89%   47.87%   -0.03%     
==========================================
  Files         161      161              
  Lines       23425    23425              
==========================================
- Hits        11220    11214       -6     
- Misses      10990    10996       +6     
  Partials     1215     1215
Flag Coverage Δ
unittests 47.87% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kruise-bot kruise-bot added size/M size/M: 30-99 and removed size/XS size/XS: 0-9 labels Mar 15, 2024
@furykerry furykerry force-pushed the fix-e2e branch 2 times, most recently from c29d601 to 57e9db9 Compare March 15, 2024 05:28
@kruise-bot kruise-bot added size/L size/L: 100-499 and removed size/M size/M: 30-99 labels Mar 15, 2024
@furykerry
Copy link
Member Author

/lgtm

@kruise-bot
Copy link

@furykerry: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@furykerry furykerry changed the title fix e2e fix e2e and limit workflow action permission Mar 18, 2024
@zmberg
Copy link
Member

zmberg commented Mar 18, 2024

/lgtm

@zmberg
Copy link
Member

zmberg commented Mar 18, 2024

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit dad39bc into openkruise:master Mar 18, 2024
33 of 34 checks passed
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
@furykerry
reduce github action permissions (openkruise#1523)
ee35acf
@liangyuanpeng liangyuanpeng mentioned this pull request Apr 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fei-Guo Fei-Guo Awaiting requested review from Fei-Guo

@FillZpp FillZpp Awaiting requested review from FillZpp

Assignees

@zmberg zmberg

Labels
approved lgtm size/L size/L: 100-499
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@furykerry @kruise-bot @zmberg