Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permission of security-events write for ghaction golangci-lint. #1582

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

liangyuanpeng
Copy link
Contributor

@liangyuanpeng liangyuanpeng commented Apr 16, 2024

Ⅰ. Describe what this PR does

Fix permission problem of golangci-lint, broken from #1523 , check https://github.com/openkruise/kruise/actions/runs/8705720546/job/23876728653

I have verifyed on my fork repo: https://github.com/liangyuanpeng/kruise/actions/runs/8707280251/job/23881898537 with below config:

  push:
    branches:
      - master
      - release-*
+    - fix_ghaction_permission

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot kruise-bot added the size/XS size/XS: 0-9 label Apr 16, 2024
@liangyuanpeng
Copy link
Contributor Author

/assign @furykerry
/assign @zmberg

@furykerry
Copy link
Member

/lgtm
/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 2753c3a into openkruise:master Apr 17, 2024
31 of 32 checks passed
@liangyuanpeng liangyuanpeng deleted the fix_ghaction_permission branch April 17, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants