Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Add proposal for path and queryParams support in Rollouts #1524

Conversation

lujiajing1126
Copy link

@lujiajing1126 lujiajing1126 commented Mar 15, 2024

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

openkruise/rollouts#205 and related PR

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zmberg for approval by writing /assign @zmberg in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot
Copy link

Welcome @lujiajing1126! It looks like this is your first PR to openkruise/kruise 🎉

@kruise-bot kruise-bot added the size/L size/L: 100-499 label Mar 15, 2024
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.94%. Comparing base (0d0031a) to head (13ea328).
Report is 34 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1524      +/-   ##
==========================================
+ Coverage   47.91%   48.94%   +1.03%     
==========================================
  Files         162      180      +18     
  Lines       23491    18803    -4688     
==========================================
- Hits        11256     9204    -2052     
+ Misses      11014     8382    -2632     
+ Partials     1221     1217       -4     
Flag Coverage Δ
unittests 48.94% <ø> (+1.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lujiajing1126 lujiajing1126 force-pushed the proposal-add-path-queryparams-as-l7-match branch from c1e8cc4 to c4331ab Compare March 18, 2024 04:10
Signed-off-by: Megrez Lu <[email protected]>
Signed-off-by: Megrez Lu <[email protected]>
Signed-off-by: Megrez Lu <[email protected]>
Signed-off-by: Megrez Lu <[email protected]>
@lujiajing1126 lujiajing1126 force-pushed the proposal-add-path-queryparams-as-l7-match branch from c4331ab to b541094 Compare May 15, 2024 07:20
Signed-off-by: Megrez Lu <[email protected]>
Signed-off-by: Megrez Lu <[email protected]>
@zmberg zmberg closed this Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants