Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust the judgment logic of whether the current ordinal needs to be updated #1751

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zybtakeit
Copy link

Ⅰ. Describe what this PR does

adjust the judgment logic of whether the current ordinal needs to be updated

Ⅱ. Does this pull request fix one issue?

fix issue:#1749

Ⅲ. Describe how to verify it

1.create a StatefulSet with ordinal and open the feature gate
2.check if the pod has been upgraded correctly

Ⅳ. Special notes for reviews

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 49.18%. Comparing base (0d0031a) to head (b91d92e).
Report is 87 commits behind head on master.

Files with missing lines Patch % Lines
pkg/controller/statefulset/stateful_set_utils.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1751      +/-   ##
==========================================
+ Coverage   47.91%   49.18%   +1.26%     
==========================================
  Files         162      191      +29     
  Lines       23491    19595    -3896     
==========================================
- Hits        11256     9638    -1618     
+ Misses      11014     8700    -2314     
- Partials     1221     1257      +36     
Flag Coverage Δ
unittests 49.18% <66.66%> (+1.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ABNER-1
Copy link
Member

ABNER-1 commented Sep 19, 2024

Hi, @zybtakeit .Thank you for your contribution.

We are contemplating redefining the term 'partition' in the context of its combination with 'start ordinal' and 'reservedIds'

@zybtakeit zybtakeit force-pushed the fix_statefulset_ordinal_revision branch from 5ae5f63 to b91d92e Compare September 19, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants