Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporter record management #66

Merged
merged 24 commits into from
Jun 5, 2024
Merged

Supporter record management #66

merged 24 commits into from
Jun 5, 2024

Conversation

mauromsl
Copy link
Member

@mauromsl mauromsl commented Jun 4, 2024

I fat fingered the merge button on #65 without a second reviewer

This closes #63 and closes #54 as well as completing some necessary yak shaving:

  • Simplifies the types of bands into a choice field called "category". Bands can now be base, calculated, or special.
  • Updates the logic and utils methods to use this field
  • Updates the tests in line with logic and utils, and while we're at it, to be more readable and maintainable
  • Starts work on As a press manager I want to manage bands from year to year #64 in the models and utils (e.g. prospective_band and get_total_revenue)

TIP! You can quickly get up and running with some sample data by running the management
command install_example_supporter_data.

@mauromsl mauromsl requested a review from ajrbyers June 4, 2024 08:36
@mauromsl mauromsl changed the title 63 supporter management Supporter record management Jun 4, 2024
Copy link
Member

@ajrbyers ajrbyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a comment about the ROR API rate limit for the management command. Its possible if the command runs fast enough that it might hit the limit.

management/commands/autofill_rors.py Outdated Show resolved Hide resolved
@ajrbyers ajrbyers assigned joemull and unassigned ajrbyers Jun 4, 2024
@joemull joemull requested a review from ajrbyers June 5, 2024 05:02
@joemull joemull assigned ajrbyers and unassigned joemull Jun 5, 2024
@ajrbyers ajrbyers merged commit 518a322 into master Jun 5, 2024
@joemull joemull deleted the 63-supporter-management branch September 20, 2024 09:33
@joemull joemull added this to the Biller UX milestone Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Management of supporter records Allow billing agents to submit supporter details on behalf of someone else
3 participants